-
Notifications
You must be signed in to change notification settings - Fork 21
use IDEA certificate manager when connecting to the cluster (#600) #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current simplistic implementation is using the IDEA setting "Accept non-trusted certificates automatically". It tells our kubernetes-client to automatically accept all certificates if the setting is enabled in IDEA. It is very limited though:
A solution to both these limitation would be to hand the IDEA certificate manager over to our kubernetes-client. This isn't possible currently because the client expect the certificate-manager and the key-manager. I need to get the ones used by the client, hand it over to IDEA and give the client the IDEA managers. The client currently wont allow me to access those, it looks as if I need a change in kubernetes-client for this. |
) Signed-off-by: Andre Dietisheim <[email protected]>
Hi @datho7561, can you please test this? You can find the steps to reproduce the issue and test this PR in #600 (comment). The variant 2, where you use the slack "Cluster Bot" is the simpler approach. There's no need to install a self-signed certificate since the cluster that the bot creates has a self-signed certificate already. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and it's working well for me!
2fbf008
to
792e904
Compare
…eveloper#600) Signed-off-by: Andre Dietisheim <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
Added unit-tests and javadoc. |
fixes #600